Skip site navigation (1) Skip section navigation (2)

Re: test/example does not support win32.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: test/example does not support win32.
Date: 2009-12-30 15:38:12
Message-ID: 200912301538.nBUFcCQ22347@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Tom Lane wrote:
> "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> writes:
> > Yes, I thinks that it is an exact idea. However, this example was not helped. 
> > fd_set complains.... 
> > Thanks!
> 
> > It seems that pg_bench takes the thing same again into consideration. 
> > Anyway,  If it is called example of end-user code, what is the evasion method
> > of fd_set? 
> 
> On reflection I think it's just wrong to expect that the examples will
> compile out-of-the-box on every platform.  The only way that that can
> possibly happen is if they depend on our configuration infrastructure,
> which is exactly what I feel they should not depend on.  Any client
> program that has ambitions of portability is going to have its own
> autoconf stuff, so injecting ours into a piece of sample code is just
> going to result in headaches.  Even including only pg_config.h would
> be a serious invasion of application namespace.
> 
> Looking at pgbench, or any other one of our client-side programs,
> is not relevant to the point here.  Those programs *are* supposed
> to rely on the PG autoconf environment.
> 
> We can certainly add some more standard #includes to the examples
> if they're obviously missing some.  But that isn't going to get us
> to a point where they'll compile everywhere without change.

Well, those example programs are pretty clean libpq apps so I don't see
why they should using platform-specific stuff.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2009-12-30 15:44:49
Subject: Re: test/example does not support win32.
Previous:From: Tom LaneDate: 2009-12-30 15:33:59
Subject: Re: test/example does not support win32.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group