Re: pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared
Date: 2009-12-28 18:49:16
Message-ID: 200912281849.nBSInGY08632@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> > Log Message:
> > -----------
> > Add PGDLLIMPORT for binary_upgrade global variables so shared object
> > libraries can access them.
>
> This change is useless, and contrary to our coding standards elsewhere.
> You need PGDLLIMPORT on the externs seen by the loadable module. We
> don't put it on the actual variable definitions.

Thanks, I will make the necessary adjustments.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message User Bmomjian 2009-12-28 18:56:11 pg-migrator - pg_migrator: Stamp 8.4.9.
Previous Message Bruce Momjian 2009-12-28 18:49:05 pgsql: Remove PGDLLIMPORT used for binary upgrade; must be on the