Skip site navigation (1) Skip section navigation (2)

pgsql: Always pass catalog id to the options validator function

From: heikki(at)postgresql(dot)org (Heikki Linnakangas)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Always pass catalog id to the options validator function
Date: 2009-12-23 12:23:59
Message-ID: 20091223122359.237AC753FB7@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Always pass catalog id to the options validator function specified in
CREATE FOREIGN DATA WRAPPER. Arguably it wasn't a bug because the
documentation said that it's passed the catalog ID or zero, but surely
we should provide it when it's known. And there isn't currently any
scenario where it's not known, and I can't imagine having one in the
future either, so better remove the "or zero" escape hatch and always
pass a valid catalog ID. Backpatch to 8.4.

Martin Pihlak

Modified Files:
--------------
    pgsql/doc/src/sgml/ref:
        create_foreign_data_wrapper.sgml (r1.5 -> r1.6)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/create_foreign_data_wrapper.sgml?r1=1.5&r2=1.6)
    pgsql/src/backend/commands:
        foreigncmds.c (r1.8 -> r1.9)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/foreigncmds.c?r1=1.8&r2=1.9)
    pgsql/src/backend/foreign:
        foreign.c (r1.5 -> r1.6)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/foreign/foreign.c?r1=1.5&r2=1.6)
    pgsql/src/test/regress/expected:
        foreign_data.out (r1.11 -> r1.12)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/foreign_data.out?r1=1.11&r2=1.12)

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2009-12-23 12:24:16
Subject: pgsql: Always pass catalog id to the options validator function
Previous:From: Bruce MomjianDate: 2009-12-23 04:10:50
Subject: pgsql: Rename pg_dump.c TypeInfo variable tinfo to tyinfo, for clarity.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group