Skip site navigation (1) Skip section navigation (2)

Re: CommitFest status/management

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Greg Smith <greg(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: CommitFest status/management
Date: 2009-12-01 12:07:25
Message-ID: 200912011207.nB1C7PP18758@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Robert Haas wrote:
> On Mon, Nov 30, 2009 at 11:08 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> >> As I have observed before, I think we need some infrastructure to help
> >> committers claim items, so we don't duplicate work.
> >
> > Robert acknowledged the need for a "claimed by committer" field in the
> > fest application, but he hasn't got round to it yet. ?In the meantime
> > I've been adding a "Taking this one..." type of comment to an entry
> > I want to claim.
> 
> Sorry I haven't gotten around to this.  Beyond being a little burned
> out a little bit, I have been a little bit under the weather and a
> little occupied with life apart from PostgreSQL, as if there were such
> a thing.  Anyway, one of the concerns I have about this is that adding
> another field to the commitfest_view page seems as though it will
> create some layout issues - the leftmost column will get squished.  I
> could (a) go ahead and do it anyway or (b) do it, but modify the
> layout in some unspecified way so that it doesn't impact the format as
> much or of course (c) not do it.  Any thoughts?
> 
> It would also like to clarify the use case for this a little bit more.
>  Is this just to track patches which committers are in the process of
> committing (or have committed)?  Or would a committer potentially set
> this on some patch that was still being reviewed, and if so would that
> mean "don't review this any more because I'm taking over" or "I'm
> planning to pick this up when the review process completes" or
> something else?

I am thinking we can just add a new status, "claimed by committer" and
not bother about adding a new column with the committer name.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2009-12-01 12:08:21
Subject: Re: Block-level CRC checks
Previous:From: Robert HaasDate: 2009-12-01 12:06:23
Subject: Re: Block-level CRC checks

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group