Skip site navigation (1) Skip section navigation (2)

Re: per-tablespace random_page_cost/seq_page_cost

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>,pgsql-hackers(at)postgresql(dot)org, Greg Stark <gsstark(at)mit(dot)edu>,Josh Berkus <josh(at)agliodbs(dot)com>
Subject: Re: per-tablespace random_page_cost/seq_page_cost
Date: 2009-11-03 12:51:52
Message-ID: 20091103125152.GB7088@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackers
Robert Haas escribió:
> On Tue, Nov 3, 2009 at 6:25 AM, Alvaro Herrera
> <alvherre(at)commandprompt(dot)com> wrote:
> >> > If this is the case, then I think we could just decide that their name
> >> > is reloptions due to hysterical reasons and be done with it.
> >>
> >> Yeah.  It's particularly unfortunate that we call them "reloptions" in
> >> the code but "storage parameters" in the documentation.  Neither is a
> >> particularly good name, and having two different ones is extra-poor.
> >> But I'm fine with leaving the names as they are and moving on, if no
> >> one objects too much.  Speak now or don't complain about it after I
> >> write the patch!
> >
> > Maybe after we move to Git we can rename them in the code?
> 
> I'm OK with renaming it before I start working on the main patch, or
> after it's committed, or never.  I just don't want to have to rebase
> it in the middle.

I think "after we move to Git" goes well after "after your patch is
committed", so we're OK.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2009-11-03 13:37:10
Subject: Re: per-tablespace random_page_cost/seq_page_cost
Previous:From: Robert HaasDate: 2009-11-03 12:49:34
Subject: Re: per-tablespace random_page_cost/seq_page_cost

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group