Skip site navigation (1) Skip section navigation (2)

Re: CF 2009-09: initial reviewing assignments

From: Abhijit Menon-Sen <ams(at)toroid(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-rrreviewers(at)postgresql(dot)org
Subject: Re: CF 2009-09: initial reviewing assignments
Date: 2009-09-16 05:38:51
Message-ID: 20090916053851.GA9771@toroid.org (view raw or flat)
Thread:
Lists: pgsql-rrreviewers
At 2009-09-14 21:08:56 -0400, robertmhaas(at)gmail(dot)com wrote:
>
> Logging configuration changes
> - Abhijit Menon-Sen <ams(at)toroid(dot)org>

I reviewed this patch. It's fine. Ready for committer as-is.

But I suggested some minor changes that I thought were useful, and
posted a new version of the patch including those changes. Besides
that, I posted a patch to implement a suggestion Peter made in his
original posting.

What status should I assign the patch now? It's "Needs Review", in
a sense, but also "Waiting on Author", "Ready for Committer", and
"Returned with Feedback" ;-)

The patch is completely trivial, before and after, so I feel a bit silly
even to ask this question. Should I just advance it to "Ready"?

(I suppose my review will show up on -hackers by the time this message
shows up on -rrreviewers.)

-- ams

In response to

Responses

pgsql-rrreviewers by date

Next:From: Robert HaasDate: 2009-09-16 16:44:06
Subject: Re: CF 2009-09: initial reviewing assignments
Previous:From: Robert HaasDate: 2009-09-15 13:55:06
Subject: Re: CF 2009-09: initial reviewing assignments

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group