Re: Savepoints in PgAdmin

Le jeudi 3 septembre 2009 à 14:08:54, Guillaume Lelarge a écrit :
> Le jeudi 3 septembre 2009 à 14:02:24, Dave Page a écrit :
> > On Thu, Sep 3, 2009 at 12:57 PM, Magnus Hagander<magnus(at)hagander(dot)net>
wrote:
> > > Good question. In general we shouldn't change the default behavior in
> > > a backpatch, but I think the use-case for the current behavior is
> > > pretty limited.
> >
> > It's not being back-patched. That code has been there for years, with
> > only one complaint that I'm aware of. The complaint is a valid one
> > though, which is why I think we should add the option for 1.12.
>
> I also think this is 1.12 only.
>
> > > AIUI, nothing at all changes for single-statement queries, right? It
> > > would only affect those that explicitly open a transaction. In which
> > > case I think it's a reasonable default to behave the same way as psql,
> > > which means change the default for pgadmin.
> > >
> > > Specifically on the patch I don't like an option named "disabled auto
> > > rollback". Negations in options suck. It shuold be "Enable auto
> > > rollback", and then whatever the default is can be argued. I'd also
> > > find it very useful if this was available as a checkbox on the query
> > > menu, not just in the options dialog. Thoughts?
> >
> > Which would do what - override the default for that window only, or
> > control the default as well? I prefer the former, but some of the
> > other options are stored for all future query windows, so there may be
> > some inconsistency there.
>
> I'll change it to "Enable auto rollback", and preserve the old default
> value. Having it on a menu in the query tool would be really useful. I
> don't have strong feelings on wether it should override the default.
> Actually, I think it would be better to overrid it only for this window.

Done. Here is the new patch. The check menu item behaves the same way than the
others, ie it completely controls the option value. I think it is more
consistent this way.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com