Re: Savepoints in PgAdmin

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-support(at)postgresql(dot)org
Cc: Dave Page <dpage(at)pgadmin(dot)org>, DUPREZ Cédric <cedric(dot)duprez(at)ifn(dot)fr>
Subject: Re: Savepoints in PgAdmin
Date: 2009-08-31 08:07:30
Message-ID: 200908311007.30912.guillaume@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-support

Le vendredi 21 août 2009 à 09:51:32, Guillaume Lelarge a écrit :
> Le vendredi 21 août 2009 à 09:14:22, Dave Page a écrit :
> > On Thu, Aug 20, 2009 at 10:09 PM, Guillaume
> >
> > Lelarge<guillaume(at)lelarge(dot)info> wrote:
> > > // If the transaction aborted for some reason, issue a rollback to
> > > cleanup. if (conn->GetTxStatus() == PGCONN_TXSTATUS_INERROR)
> > > conn->ExecuteVoid(wxT("ROLLBACK;"));
> > >
> > > We should perhaps have an option to enable/disable this behaviour.
> > > Dave, what do you think about this? should I add a ticket on this
> > > issue?
> >
> > Yes, I *think* it'd be appropriate to make that optional. If memory
> > serves, it is only there to cleanup for the user. I'm not in a
> > position to check at the moment though I'm afraid.
>
> Thanks. Logged in as http://code.pgadmin.org/trac/ticket/47 .

Here is a patch to add this feature. It adds a new setting ("Disable Auto
ROOLBACK") in the Query tag of the Options Dialog. This is of course for 1.11.

Comments?

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

Attachment Content-Type Size
ticket47_v1.patch text/x-patch 4.0 KB

In response to

Responses

Browse pgadmin-support by date

  From Date Subject
Next Message Robin Martin 2009-08-31 09:32:45 Tweaks: SQL Query Tool
Previous Message Guillaume Lelarge 2009-08-30 16:32:08 Re: 5862-73E9-2F3D problem with sequence