Skip site navigation (1) Skip section navigation (2)

pgsql: Fix old bug in log_autovacuum_min_duration code: it was relying

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix old bug in log_autovacuum_min_duration code: it was relying
Date: 2009-08-12 18:23:56
Message-ID: 20090812182356.098E875331E@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Fix old bug in log_autovacuum_min_duration code: it was relying on being able
to access a Relation entry it had just closed.  I happened to be testing with
CLOBBER_CACHE_ALWAYS, which made this a guaranteed core dump (at least on
machines where sprintf %s isn't forgiving of a NULL pointer).  It's probably
quite unlikely that it would fail in the field, but a bug is a bug.  Fix by
moving the relation_close call down past the logging action.

Tags:
----
REL8_4_STABLE

Modified Files:
--------------
    pgsql/src/backend/commands:
        analyze.c (r1.139 -> r1.139.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/analyze.c?r1=1.139&r2=1.139.2.1)

pgsql-committers by date

Next:From: Tom LaneDate: 2009-08-12 18:24:03
Subject: pgsql: Fix old bug in log_autovacuum_min_duration code: it was relying
Previous:From: Tom LaneDate: 2009-08-12 18:23:49
Subject: pgsql: Fix old bug in log_autovacuum_min_duration code: it was relying

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group