Skip site navigation (1) Skip section navigation (2)

Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)
Date: 2009-08-11 23:06:04
Message-ID: 200908112306.n7BN64414877@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Andrew Dunstan escribi:
> >> Here's the extract attached.  I replace tabs with a literal '\t' so
> >> I could see what it was doing. I can't make much head or tail of it
> >> either.
> 
> > pgindent uses entab/detab, which counts spaces and replaces them with
> > tabs.  It is wildly undocumented.  See src/tools/entab
> 
> What surprises me is that it seems to be changing lines that have been
> there for quite some time.  Bruce, have you been changing pgindent
> underneath us?

Not unless I am CVS committing without showing anyone.  ;-)

These are the only commits I see recently, which are harmless:

	revision 1.101
	date: 2009/06/11 22:21:44;  author: momjian;  state: Exp;  lines: +7 -2
	Document struct/union problem with pgindent.
	----------------------------
	revision 1.100
	date: 2008/11/03 15:56:47;  author: momjian;  state: Exp;  lines: +2 -2
	Small shell syntax improvement.
	----------------------------
	revision 1.99
	date: 2008/04/16 21:03:08;  author: momjian;  state: Exp;  lines: +2 -2
	Ignore blank lines in typedef file.
	----------------------------
	revision 1.98
	date: 2008/01/16 20:13:44;  author: momjian;  state: Exp;  lines: +2 -2
	Improve usage message for pgindent.
	----------------------------
	revision 1.97
	date: 2007/12/21 14:20:36;  author: momjian;  state: Exp;  lines: +11
	-2008
	Modify pgindent to use an external typedefs file rather than included
	list.

and entab is similarly unchanged:

	revision 1.18
	date: 2007/02/08 11:10:27;  author: petere;  state: Exp;  lines: +2 -2
	Normalize fgets() calls to use sizeof() for calculating the buffer size
	where possible, and fix some sites that apparently thought that fgets()
	will overwrite the buffer by one byte.
	
	Also add some strlcpy() to eliminate some weird memory handling.

I am stumped, but can keep researching.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Albert Cervera i ArenyDate: 2009-08-11 23:08:54
Subject: Re: Alpha 1 release notes
Previous:From: Paul MatthewsDate: 2009-08-11 22:58:19
Subject: Re: Quick pointer required re indexing geometry

pgsql-committers by date

Next:From: Bruce MomjianDate: 2009-08-11 23:12:50
Subject: Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)
Previous:From: Peter EisentrautDate: 2009-08-11 22:22:34
Subject: Re: [COMMITTERS] pgsql: Ship documentation without intermediate tarballs Documentation

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group