Re: Small annoyance in pgAdmin 1.10

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-support(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>, Rainer Bauer <usenet(at)munnin(dot)com>
Subject: Re: Small annoyance in pgAdmin 1.10
Date: 2009-08-10 18:46:10
Message-ID: 200908102046.10471.guillaume@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-support

Le lundi 10 août 2009 à 15:17:17, Dave Page a écrit :
> On Mon, Aug 10, 2009 at 2:08 PM, Dave Page<dpage(at)pgadmin(dot)org> wrote:
> > On Mon, Aug 10, 2009 at 2:03 PM, Dave Page<dpage(at)pgadmin(dot)org> wrote:
> >>> If I can't use a pointer, I don't see how I can do this. Or should I
> >>> just remove the MessageBox?
> >>>
> >>> As per my understanding, you always can use reference in place of
> >>> pointer.
> >>
> >> Yes, just pass by reference:
> >>
> >> bool generateSQL(const wxString &query);
> >
> > Of course, you might want to leave out the const decoration.
>
> Looking at this a little more closely, why not just add a new function:
>
> int gqbController::getTableCount() { return model->tablesCount(); }
>
> and call that from frmQuery? Assuming it can't already see model....

Why didn't I think about this quite easy solution? no issue with pointer or
reference. So here is the patch.

Thanks Dave and Ashesh :)

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

Attachment Content-Type Size
40_2.patch text/x-patch 1.2 KB

In response to

Responses

Browse pgadmin-support by date

  From Date Subject
Next Message Guillaume Lelarge 2009-08-10 18:51:08 Re: Malfunction in dropping database with pgAdmin
Previous Message Oliver Keller 2009-08-10 14:13:16 can't invoke the debugger