| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Brendan Jurd <direvus(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Euler Taveira de Oliveira <euler(at)timbira(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: to_char, support for EEEE format |
| Date: | 2009-08-10 14:56:14 |
| Message-ID: | 20090810145614.GA4796@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Brendan Jurd escribió:
> 2009/8/9 Alvaro Herrera <alvherre(at)commandprompt(dot)com>:
> > I noticed an ugly pattern in NUMDesc_prepare calling a cleanup function
> > before every ereport(ERROR). I think it's cleaner to replace that with
> > a PG_TRY block; see attached.
>
> Looks nice -- although doesn't have anything to do with the EEEE patch
> so perhaps deserves its own thread?
Yes, it just popped up while skimming the patch.
> > I didn't go over the patch in much more detail. (But the
> > numeric_out_sci business got me thinking.)
>
> Got you thinking about what? I'd welcome any comments you have.
I wondered if it should just return char *. If we want to have this
functionality as its own fmgr-blessed function, shouldn't it return
text instead of cstring?
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2009-08-10 14:56:45 | Re: [PATCH] "could not reattach to shared memory" on Windows |
| Previous Message | Tom Lane | 2009-08-10 14:54:16 | Re: machine-readable explain output v4 |