Skip site navigation (1) Skip section navigation (2)

pgsql: Cause pg_proc.probin to be declared as text, not bytea.

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Cause pg_proc.probin to be declared as text, not bytea.
Date: 2009-08-04 04:04:12
Message-ID: 20090804040412.5A3C975331E@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Log Message:
-----------
Cause pg_proc.probin to be declared as text, not bytea.  Everything was
already treating it as text anyway, to the point that I couldn't find anything
to change except the datatype markings in catalog/*.h.  The only effect that
the bytea declaration had was to cause byteaout() to be invoked when pg_dump
(or another client program) inspected the column value.  Since pg_dump wasn't
expecting that, but just treating what it got as text, the net result is that
dump and reload would mangle any backslashes or non-ASCII characters in the
filename string for a C-language function.  That is a very long-standing bug,
but given the lack of field complaints it doesn't seem worth trying to find
a back-patchable fix.  We'll just make this change to fix it going forward.

This change will also forestall problems after the planned change to let bytea
emit hex output instead of escaped characters.

Modified Files:
--------------
    pgsql/doc/src/sgml:
        catalogs.sgml (r2.204 -> r2.205)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/catalogs.sgml?r1=2.204&r2=2.205)
    pgsql/src/include/catalog:
        catversion.h (r1.536 -> r1.537)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/catversion.h?r1=1.536&r2=1.537)
        pg_attribute.h (r1.150 -> r1.151)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_attribute.h?r1=1.150&r2=1.151)
        pg_proc.h (r1.548 -> r1.549)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_proc.h?r1=1.548&r2=1.549)

Responses

pgsql-hackers by date

Next:From: Joe ConwayDate: 2009-08-04 04:21:54
Subject: Re: async notification patch for dblink
Previous:From: KaiGai KoheiDate: 2009-08-04 03:53:24
Subject: Re: SE-PostgreSQL Specifications

pgsql-committers by date

Next:From: Greg StarkDate: 2009-08-04 11:33:23
Subject: Re: pgsql: Cause pg_proc.probin to be declared as text, not bytea.
Previous:From: User MaosenDate: 2009-08-04 03:45:22
Subject: pgexternaltable - src:

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group