Skip site navigation (1) Skip section navigation (2)

Re: Second l10n patch

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Cc: Dave Page <dpage(at)pgadmin(dot)org>, Marek Černocký <marek(at)manet(dot)cz>
Subject: Re: Second l10n patch
Date: 2009-08-03 11:19:14
Message-ID: 200908031319.14446.guillaume@lelarge.info (view raw or flat)
Thread:
Lists: pgadmin-hackers
Le lundi 3 août 2009 à 13:04:34, Dave Page a écrit :
> 2009/8/3 Guillaume Lelarge <guillaume(at)lelarge(dot)info>:
> > Le lundi 3 août 2009 à 12:33:56, Guillaume Lelarge a écrit :
> >> Le lundi 3 août 2009 à 11:57:02, Dave Page a écrit :
> >> > 2009/8/1 Marek Černocký <marek(at)manet(dot)cz>:
> >> > > Hi,
> >> > >
> >> > > I send patch. It solves translation for object type names in
> >> > > reports.
> >> >
> >> > Should code like this use wxPLURAL?
> >> >
> >> > int section = report->XmlCreateSection(wxString::Format(_("%s
> >> > dependents"), object->GetTranslatedTypeName().c_str()));
> >>
> >> No. We need wxPLURAL when we have a variable that tells us if it is
> >> plural or not. In this code, there's nothing that gives us a hint about
> >> it.
> >>
> >> Note that I didn't actually try this patch. Only read it.
> >
> > Just tried it, and it works the way I think it should. I can commit it if
> > you want.
>
> Sure - thanks.

Done. Sorry for the two commits, I forgot the CHANGELOG file.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

In response to

pgadmin-hackers by date

Next:From: Dave PageDate: 2009-08-03 11:26:12
Subject: Re: Change: l10n patch
Previous:From: svnDate: 2009-08-03 11:18:33
Subject: SVN Commit by guillaume: r7999 - trunk/pgadmin3

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group