Skip site navigation (1) Skip section navigation (2)

Re: improvements for dict_xsyn extended synonym dictionary - RRR

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org
Cc: "Sergey V(dot) Karpov" <karpov(at)sao(dot)ru>
Subject: Re: improvements for dict_xsyn extended synonym dictionary - RRR
Date: 2009-07-29 22:59:49
Message-ID: 200907300059.50365.andres@anarazel.de (view raw or flat)
Thread:
Lists: pgsql-hackers
Hi Sergey,

Sorry that the second round took almost as long as the first one...

On Monday 27 July 2009 12:01:46 Sergey V. Karpov wrote:
> > - Imho mode=MAP should error out if keeporig is false
> > - I personally find the the names for the different modes a bit
> > nondescriptive. One possibility would be to introduce parameters like:
> > 	- matchorig
> > 	- matchsynonym
> > 	- keeporig
> > 	- keepsynonym
> > That sounds way much easier to grasp for me.
> Yes, I agree. In such a way user has the complete (and more
> straightforward) control over the dictionary behaviour.
>
> Here is the revised patch version, with following options:
>
>      * matchorig controls whether the original word is accepted by the
>        dictionary. Default is true.
>
>      * keeporig controls whether the original word is included (if true)
>        in results, or only its synonyms (if false). Default is true.
>
>      * matchsynonyms controls whether any of the synonyms is accepted by
>        the dictionary (if true). Default is false.
>
>      * keepsynonyms controls whether synonyms are returned by the
>        dictionary (if true). Default is true.
>
> Defaults are set to keep default behaviour compatible with original
> version.
Looks nice. The only small gripe I have is that the patch adds trailing 
whitespaces at a lot of places...

Except maybe that I do see no need for changes anymore...

Andres

In response to

Responses

pgsql-hackers by date

Next:From: Steve PrenticeDate: 2009-07-29 23:55:05
Subject: RFD: Don't force plpgsql IN parameters to constant
Previous:From: Josh WilliamsDate: 2009-07-29 21:31:53
Subject: Re: multi-threaded pgbench

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group