Skip site navigation (1) Skip section navigation (2)

Re: BUG #4941: pg_stat_statements crash

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org, alr(dot)nospamforme(at)gmail(dot)com, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #4941: pg_stat_statements crash
Date: 2009-07-27 03:48:58
Message-ID: 20090727034858.GI10327@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
Tom Lane escribió:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Itagaki Takahiro escribi:
> >> Here is a patch to fix pg_stat_statements on Windows.
> 
> > Hmm, it seems the comment just above the patched line needs to be fixed.
> 
> I looked at that and decided it was OK as-is.  How do you want to
> change it?

The reason that it doesn't need locks is not that there's no other
process running, but that it was already initialized, in the case when
found is false.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2009-07-27 03:58:59
Subject: Re: BUG #4941: pg_stat_statements crash
Previous:From: Tom LaneDate: 2009-07-27 03:38:18
Subject: Re: BUG #4941: pg_stat_statements crash

pgsql-bugs by date

Next:From: Tom LaneDate: 2009-07-27 03:58:59
Subject: Re: BUG #4941: pg_stat_statements crash
Previous:From: Tom LaneDate: 2009-07-27 03:38:18
Subject: Re: BUG #4941: pg_stat_statements crash

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group