| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: autogenerating headers & bki stuff |
| Date: | 2009-07-25 07:21:08 |
| Message-ID: | 200907251021.09390.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tuesday 30 June 2009 06:59:51 Robert Haas wrote:
> The attached patch merges all of the logic currently in genbki.sh and
> Gen_fmgrtab.{sh,pl} into a single script called gen_catalog.pl. It
> then extends that logic to generate all of the Anum_* and Natts_*
> constants, as well as the Schema_pg_* declarations for the bootstrap
> tables.
I see a potential problem with the introduction of the catalog/anum.h header,
to hold the Anum_... defines. This looks like it could be a significant break
in the backend API, as evidenced by the fact that plperl and dblink no longer
compile with this change.
I think a less invasive change would be to include anum.h into all the
catalog/pg_*.h headers, so that the external interface stays the same.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2009-07-25 08:18:22 | Re: Proposal: More portable way to support 64bit platforms |
| Previous Message | Jaime Casanova | 2009-07-25 06:41:18 | Re: Determining client_encoding from client locale |