In a non-hashed Agg node, reset the "aggcontext" at group boundaries, instead
of individually pfree'ing pass-by-reference transition values. This should
be at least as fast as the prior coding, and it has the major advantage of
clearing out any working data an aggregate function may have stored in or
underneath the aggcontext. This avoids memory leakage when an aggregate
such as array_agg() is used in GROUP BY mode. Per report from Chris Spotts.
Back-patch to 8.4. In principle the problem could arise in prior versions,
but since they didn't have array_agg the issue seems not critical.
nodeAgg.c (r1.167 -> r220.127.116.11)
array_userfuncs.c (r1.31 -> r18.104.22.168)
pgsql-committers by date
|Next:||From: Tom Lane||Date: 2009-07-23 21:27:10|
|Subject: pgsql: Save a few cycles in EXPLAIN and related commands by not |
|Previous:||From: Tom Lane||Date: 2009-07-23 20:45:27|
|Subject: pgsql: In a non-hashed Agg node, reset the "aggcontext" at group |