Do a conditional SPI_push/SPI_pop when replanning a query in
RevalidateCachedPlan. This is to avoid a "SPI_ERROR_CONNECT" failure when
the planner calls a SPI-using function and we are already inside one.
The alternative fix is to expect callers of RevalidateCachedPlan to do this,
which seems likely to result in additional hard-to-detect bugs of omission.
Per reports from Frank van Vugt and Marek Lewczuk.
Back-patch to 8.3. It's much harder to trigger the bug in 8.3, due to a
smaller set of cases in which plans can be invalidated, but it could happen.
(I think perhaps only a SI reset event could make 8.3 fail here, but that's
certainly within the realm of possibility.)
plancache.c (r126.96.36.199 -> r188.8.131.52)
pgsql-committers by date
|Next:||From: Tom Lane||Date: 2009-07-14 20:24:10|
|Subject: pgsql: Tweak the core scanner so that it can be used by plpgsql too.|
|Previous:||From: Tom Lane||Date: 2009-07-14 15:37:55|
|Subject: pgsql: Do a conditional SPI_push/SPI_pop when replanning a query in |