Skip site navigation (1) Skip section navigation (2)

Re: PostgreSQL Developer meeting minutes up

From: Aidan Van Dyk <aidan(at)highrise(dot)ca>
To: Markus Wanner <markus(at)bluegap(dot)ch>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>,Magnus Hagander <magnus(at)hagander(dot)net>,Andrew Dunstan <andrew(at)dunslane(dot)net>,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PostgreSQL Developer meeting minutes up
Date: 2009-05-29 15:34:35
Message-ID: 20090529153435.GA15213@yugib.highrise.ca (view raw or flat)
Thread:
Lists: pgsql-hackers
* Markus Wanner <markus(at)bluegap(dot)ch> [090529 11:18]:
> Hi,
>
> Quoting "Aidan Van Dyk" <aidan(at)highrise(dot)ca>:
>> * Markus Wanner <markus(at)bluegap(dot)ch> [090529 11:06]:
>>> Comparison of the head of each branch between git and CVS (modulo CVS
>>> keyword expansion, which I've filtered out):
>>
>> How did you filter it out
>
> With perl some regexes.
>
>> and without the filtering out, how does it do?
>
> Uh.. why is that of interest? With content hashing, these keywords do  
> more harm than good.

Yes, but the point is you want an exact replica of CVS right?  You're
git repo should have $PostgreSQL$ and the cvs export/checkout (you do
use -kk right) should also have $PostgreSQL$.

The 3 parsecvs errors were that it *didn't* recognoze the strange
$PostgreSQL ... Exp $ expansion that cvs did.

But it's important, because on *some* files you *do* want expanded
"keywords" (like the $OpenBSD ... Exp $.  One of the reasons pg CVS went
to the $PostgreSQL$ keyword (I'm guessing) was so they could explictly
de-couple them from other keywords that they didn't want munging on.

So, I wouldn't consider any conversion good unless it had all these:
	parsecvs-master:contrib/pgcrypto/crypt-des.c: * $FreeBSD: src/secure/lib/libcrypt/crypt-des.c,v 1.12 1999/09/20 12:39:20 markm Exp $
	parsecvs-master:contrib/pgcrypto/crypt-md5.c: * $FreeBSD: src/lib/libcrypt/crypt-md5.c,v 1.5 1999/12/17 20:21:45 peter Exp $
	parsecvs-master:contrib/pgcrypto/md5.c:/*          $KAME: md5.c,v 1.3 2000/02/22 14:01:17 itojun Exp $     */
	parsecvs-master:contrib/pgcrypto/md5.h:/*          $KAME: md5.h,v 1.3 2000/02/22 14:01:18 itojun Exp $     */
	parsecvs-master:contrib/pgcrypto/rijndael.c:/*  $OpenBSD: rijndael.c,v 1.6 2000/12/09 18:51:34 markus Exp $ */
	parsecvs-master:contrib/pgcrypto/rijndael.h: *  $OpenBSD: rijndael.h,v 1.3 2001/05/09 23:01:32 markus Exp $ */
	parsecvs-master:contrib/pgcrypto/sha1.c:/*         $KAME: sha1.c,v 1.3 2000/02/22 14:01:18 itojun Exp $    */
	parsecvs-master:contrib/pgcrypto/sha1.h:/*         $KAME: sha1.h,v 1.4 2000/02/22 14:01:18 itojun Exp $    */
	parsecvs-master:contrib/pgcrypto/sha2.c:/*      $OpenBSD: sha2.c,v 1.6 2004/05/03 02:57:36 millert Exp $        */
	parsecvs-master:contrib/pgcrypto/sha2.h:/*      $OpenBSD: sha2.h,v 1.2 2004/04/28 23:11:57 millert Exp $        */
	parsecvs-master:src/backend/port/darwin/system.c: * $FreeBSD: src/lib/libc/stdlib/system.c,v 1.6 2000/03/16 02:14:41 jasone Exp $
	parsecvs-master:src/port/crypt.c:/*     $NetBSD: crypt.c,v 1.18 2001/03/01 14:37:35 wiz Exp $   */
	parsecvs-master:src/port/crypt.c:__RCSID("$NetBSD: crypt.c,v 1.18 2001/03/01 14:37:35 wiz Exp $");
	parsecvs-master:src/port/qsort.c:/*     $NetBSD: qsort.c,v 1.13 2003/08/07 16:43:42 agc Exp $   */
	parsecvs-master:src/port/qsort_arg.c:/* $NetBSD: qsort.c,v 1.13 2003/08/07 16:43:42 agc Exp $   */
	parsecvs-master:src/port/strlcat.c: *   $OpenBSD: strlcat.c,v 1.13 2005/08/08 08:05:37 espie Exp $      */
	parsecvs-master:src/port/strlcpy.c:/*   $OpenBSD: strlcpy.c,v 1.11 2006/05/05 15:27:38 millert Exp $    */

As well as stuff like:
	parsecvs-master:src/backend/access/index/genam.c: *       $PostgreSQL$
	parsecvs-master:src/backend/access/index/indexam.c: *     $PostgreSQL$
	parsecvs-master:src/backend/access/nbtree/Makefile:#    $PostgreSQL$
	parsecvs-master:src/backend/access/nbtree/README:$PostgreSQL$
	parsecvs-master:src/backend/access/nbtree/nbtcompare.c: *         $PostgreSQL$
	parsecvs-master:src/backend/access/nbtree/nbtinsert.c: *          $PostgreSQL$
	parsecvs-master:src/backend/access/nbtree/nbtpage.c: *    $PostgreSQL$
	parsecvs-master:src/backend/access/nbtree/nbtree.c: *     $PostgreSQL$
	parsecvs-master:src/backend/access/nbtree/nbtsearch.c: *          $PostgreSQL$

Basically, identical what to a cvs export/checkout/update gives you with
a "-kk".

But I'm picky ;-)

a.

-- 
Aidan Van Dyk                                             Create like a god,
aidan(at)highrise(dot)ca                                       command like a king,
http://www.highrise.ca/                                   work like a slave.

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2009-05-29 15:35:44
Subject: Re: plperl error format vs plpgsql error format vs pgTAP
Previous:From: Andrew DunstanDate: 2009-05-29 15:31:48
Subject: Re: search_path vs extensions

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group