Re: ALTER TABLE ... ALTER COLUMN ... SET DISTINCT

From: Joshua Tolley <eggyknap(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ALTER TABLE ... ALTER COLUMN ... SET DISTINCT
Date: 2009-05-05 02:41:45
Message-ID: 20090505024137.GC16776@eddie
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 04, 2009 at 10:13:31PM -0400, Robert Haas wrote:

<nit>
> + own analysis indicates otherwie). When set to a negative value, which
s/otherwie/otherwise
</nit>

A question: why does attdistinct become entry #5 instead of going at the end?
I assume it's because the order here controls the column order, and it makes
sense to have attdistinct next to attstattarget, since they're related. Is
that right? Thanks in advance...

> --- 185,210 ----
> * ----------------
> */
>
> ! #define Natts_pg_attribute 19
> #define Anum_pg_attribute_attrelid 1
> #define Anum_pg_attribute_attname 2
> #define Anum_pg_attribute_atttypid 3
> #define Anum_pg_attribute_attstattarget 4
> ! #define Anum_pg_attribute_attdistinct 5
> ! #define Anum_pg_attribute_attlen 6
> ! #define Anum_pg_attribute_attnum 7

- Josh / eggyknap

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message PFC 2009-05-05 09:15:51 Re: [HACKERS] high shared buffer and swap
Previous Message Robert Haas 2009-05-05 02:13:31 Re: ALTER TABLE ... ALTER COLUMN ... SET DISTINCT