pgsql: When checking for datetime field overflow, we should allow a

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: When checking for datetime field overflow, we should allow a
Date: 2009-05-01 19:29:20
Message-ID: 20090501192920.E83CA75407B@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
When checking for datetime field overflow, we should allow a fractional-second
part that rounds up to exactly 1.0 second. The previous coding rejected input
like "00:12:57.9999999999999999999999999999", with the exact number of nines
needed to cause failure varying depending on float-timestamp option and
possibly on platform. Obviously this should round up to the next integral
second, if we don't have enough precision to distinguish the value from that.
Per bug #4789 from Robert Kruus.

In passing, fix a missed check for fractional seconds in one copy of the
"is it greater than 24:00:00" code.

Broken all the way back, so patch all the way back.

Tags:
----
REL8_2_STABLE

Modified Files:
--------------
pgsql/src/backend/utils/adt:
datetime.c (r1.174.2.5 -> r1.174.2.6)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/datetime.c?r1=1.174.2.5&r2=1.174.2.6)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-05-01 19:29:27 pgsql: When checking for datetime field overflow, we should allow a
Previous Message Tom Lane 2009-05-01 19:29:13 pgsql: When checking for datetime field overflow, we should allow a