Skip site navigation (1) Skip section navigation (2)

Re: Keyword list sanity check

From: David Fetter <david(at)fetter(dot)org>
To: Andy Lester <andy(at)petdance(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>,Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Keyword list sanity check
Date: 2009-04-30 16:40:50
Message-ID: 20090430164050.GN31039@fetter.org (view raw or flat)
Thread:
Lists: pgsql-hackers
On Thu, Apr 30, 2009 at 11:39:33AM -0500, Andy Lester wrote:
>
> On Apr 30, 2009, at 6:41 AM, Robert Haas wrote:
>
>>> Please clean up this code at least to the point where it's
>>> strict-clean, which means putting "use strict;" right after the
>>> shebang line and not checking it in until it runs that way.
>>
>> And "use warnings;", too.
>
>
> I'll prob'ly come up with a policy file for Perl::Critic and a make
> target for perlcritic.

The current code has a bunch of 5s in it, so it's a target-rich
environment :)

Cheers,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

pgsql-hackers by date

Next:From: David FetterDate: 2009-04-30 19:11:00
Subject: Re: Keyword list sanity check
Previous:From: Bruce MomjianDate: 2009-04-30 16:40:04
Subject: Re: Keyword list sanity check

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group