Skip site navigation (1) Skip section navigation (2)

Re: Randomly placed definition of S_ISDIR() inpsql/copy.c

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Randomly placed definition of S_ISDIR() inpsql/copy.c
Date: 2009-04-26 00:39:07
Message-ID: 20090426003907.GB9166@fetter.org (view raw or flat)
Thread:
Lists: pgsql-hackers
On Sat, Apr 25, 2009 at 04:35:21PM -0400, Tom Lane wrote:
> Why does psql/copy.c contain this?
> 
> #if defined(WIN32) && !defined(S_ISDIR)
> #define __S_ISTYPE(mode, mask)	(((mode) & S_IFMT) == (mask))
> #define S_ISDIR(mode)	 __S_ISTYPE((mode), S_IFDIR)
> #endif
> 
> Surely a better place for such a thing is src/include/port/win32.h
> ... where indeed there already is a definition of S_ISDIR().  So I
> think this is dead code as well as poor style.  Any objection to
> seeing what happens if we remove it?

Nope :)

Cheers,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

pgsql-hackers by date

Next:From: Brendan JurdDate: 2009-04-26 01:38:22
Subject: Re: WIP: to_char, support for EEEE format
Previous:From: Tom LaneDate: 2009-04-25 20:35:21
Subject: Randomly placed definition of S_ISDIR() in psql/copy.c

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group