Re: pgsql: Make new strings more alike previously existing messages.

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make new strings more alike previously existing messages.
Date: 2009-04-14 00:06:34
Message-ID: 20090414000634.GM7709@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:

> /* Can't do single-txn mode with multiple connections */
> if (opts->single_txn && opts->number_of_jobs > 1)
> {
> ! fprintf(stderr, _("%s: options -1/--single-transaction and -j/--jobs cannot be used together\n"),
> progname);
> exit(1);
> }
>
> As the comment and the code itself show, "-j 1" works just fine with
> --single-transaction. The original wording reflected that, the new does
> not.

Hmm, I didn't realize that you could usefully pass -j1 ... now I realize
that it even works in Make. You're right, the new message is bogus.
I'll revert this part.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2009-04-14 00:06:35 pgsql: pg_restore -jN does not equate "multiple jobs", so partly revert
Previous Message Tom Lane 2009-04-13 22:57:00 Re: pgsql: Make new strings more alike previously existing messages.