pgsql: Fix a rare race condition when commit_siblings > 0 and a

From: heikki(at)postgresql(dot)org (Heikki Linnakangas)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix a rare race condition when commit_siblings > 0 and a
Date: 2009-03-31 05:18:43
Message-ID: 20090331051843.F042A754ADE@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix a rare race condition when commit_siblings > 0 and a transaction commits
at the same instant as a new backend is spawned. Since CountActiveBackends()
doesn't hold ProcArrayLock, it needs to be prepared for the case that a
pointer at the end of the proc array is still NULL even though numProcs says
it should be valid, since it doesn't hold ProcArrayLock. Backpatch to 8.1.
8.0 and earlier had this right, but it was broken in the split of PGPROC and
sinval shared memory arrays.

Per report and proposal by Marko Kreen.

Tags:
----
REL8_2_STABLE

Modified Files:
--------------
pgsql/src/backend/storage/ipc:
procarray.c (r1.19 -> r1.19.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/ipc/procarray.c?r1=1.19&r2=1.19.2.1)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2009-03-31 05:18:47 pgsql: Fix a rare race condition when commit_siblings > 0 and a
Previous Message Heikki Linnakangas 2009-03-31 05:18:39 pgsql: Fix a rare race condition when commit_siblings > 0 and a