Re: PQinitSSL broken in some use casesf

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Andrew Chernow <ac(at)esilo(dot)com>, Merlin Moncure <mmoncure(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PQinitSSL broken in some use casesf
Date: 2009-03-30 18:31:47
Message-ID: 200903301831.n2UIVlA19852@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Tom Lane wrote:
> >> And we get into the whole question of error handling, which is what
> >> shot down that proposal last time.
>
> > Can you remind me of the details? I don't remember that issue.
> > Currently PQinitSSL() returns void, so I don't see an issue there.
>
> The point is exactly the same as the complaint about turning PQinitSSL's
> argument into a bitmask: if you are trying to define an extensible API
> then you need a way for the app to determine whether all the bits it
> passed were recognizable by the library.

It seems having the init function return the bits it recognized would be
the logical return value.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2009-03-30 18:36:52 Re: More message encoding woes
Previous Message Andrew Chernow 2009-03-30 18:28:59 Re: PQinitSSL broken in some use casesf