From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: i18n doc patch |
Date: | 2009-03-29 19:56:50 |
Message-ID: | 200903292156.50461.guillaume@lelarge.info |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Le dimanche 29 mars 2009 à 17:47:39, Magnus Hagander a écrit :
> Guillaume Lelarge wrote:
> > Le dimanche 29 mars 2009 à 16:14:09, Guillaume Lelarge a écrit :
> >> Le dimanche 29 mars 2009 à 16:06:44, Magnus Hagander a écrit :
> >>> Guillaume Lelarge wrote:
> >>>> [...]
> >>>> This patch enables the use of translated manuals for pgAdmin on the
> >>>> official website. It simply checks the availability of the displayed
> >>>> file for the choosen lang and defaults to en_US if it doesn't.
> >>>
> >>> Was there supposed to be a patch attached? :-)
> >>
> >> Yes, I forgot it.
> >
> > New patch on this mail.
> >
> >>>> It seems to work on this URL:
> >>>> http://wwwdevel.pgadmin.org/docs/dev/bugreport.html?lang=fr_FR
> >>>
> >>> Um, that link gives me a bunch of PHP error messages. but the messages
> >>> are in french, so that part worked :-D
> >>
> >> Well, it seems a script fetches the new pages from the SVN repo, but
> >> gives them a 660 rights, for user and group root. So it doesn't seem to
> >> be readable. The en_US docs are 644, which is way better. But I don't
> >> know how to change this, I don't think I have the right.
> >
> > In fact, I have the right with sudo. Done, it should be better and all
> > the french manual is now available on wwwdevel.
>
> Yeah. I recall having that issue when I did postgresql.org web work ont
> hat machine.
>
> However, I think it outlines the fact that the patch needs more error
> checking, because dumping raw PHP error output into the browser is Not A
> Good Thing....
>
Yes, that's right. The patch I have now does not really satisfy me, but I
don't know how I can get a better solution. Anyways, get a look at the patch
attached, and tell me if you were thinking about something else.
--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com
Attachment | Content-Type | Size |
---|---|---|
i18ndocs.patch | text/x-patch | 1.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2009-03-29 20:14:12 | Re: i18n doc patch |
Previous Message | Magnus Hagander | 2009-03-29 15:47:39 | Re: i18n doc patch |