| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: building pg_dump doesn't work |
| Date: | 2009-03-03 23:33:15 |
| Message-ID: | 20090303233315.GH4482@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> I think this is probably going in the wrong direction. The reason
> gram.h isn't already in the main include tree is that we don't *want*
> all and sundry depending on it --- we have very carefully minimized
> the number of files that depend on the grammar's symbol codes.
>
> ISTM that pg_dump doesn't actually care about the symbol codes, it
> just needs a list of known keywords.
Hmm, I had thought that pg_dump only wanted the header file, not the
keywords.o object file. I now see that I was wrong. I agree that your
proposed solution is a lot better. I'll see about it.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | xuan--2009.03--submitbug--support--postgresql.org | 2009-03-04 01:37:10 | BUG #4689: Expanding the length of a VARCHAR column should not induce a table rewrite |
| Previous Message | Tom Lane | 2009-03-03 22:08:00 | We will do releases soon because of bug #4680; please help test |