Why do we keep UnusedLock1 in LWLockId?

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Why do we keep UnusedLock1 in LWLockId?
Date: 2009-03-03 06:52:22
Message-ID: 20090303154657.8F29.52131E4D@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

There is UnusedLock1 in LWLockId enumerations in storage/lwlock.h .
| UnusedLock1, /* FreeSpaceMapLock used to be here */

I thought it is for keeping LWLockId same as 8.3 at first,
but we've already split SInvalLock to SInvalReadLock and
SInvalWriteLock. So the IDs are changed anyway.

Are there any reason to keep UnusedLock1 there?
Or can we remove it simpley?

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2009-03-03 07:17:06 SIGHUP during recovery
Previous Message Fujii Masao 2009-03-03 04:58:25 Re: V4 of PITR performance improvement for 8.4