Skip site navigation (1) Skip section navigation (2)

Re: Allow on/off as input texts for boolean.

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Allow on/off as input texts for boolean.
Date: 2009-02-20 08:48:44
Message-ID: 20090220174642.9FD7.52131E4D@oss.ntt.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackers
Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:

> ITAGAKI Takahiro wrote:
> > Here is a patch to allow 'on' and 'off' as input texts for boolean.
> 
> Regarding your FIXME comment, I think parse_bool* should be in bool.c 
> and declared in builtins.h, which guc.c already includes. 
> (Conceptually, the valid format of a bool should be drived by the 
> boolean type, not the GUC system, I think.)

Here is an updated patch to move parse_bool* into bool.c.
I also added tests of on/off values to the regression test.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center


Attachment: boolin_accepts_onoff.2.patch
Description: application/octet-stream (9.1 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2009-02-20 09:16:00
Subject: Re: Doubts about EvalPlanQual
Previous:From: Heikki LinnakangasDate: 2009-02-20 07:10:09
Subject: Re: GIN fast insert

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group