| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog, |
| Date: | 2009-02-11 01:23:12 |
| Message-ID: | 20090211012311.GA8924@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Note that it introduces a LEFT JOIN on pg_class to itself that's always
> > present, even for server versions that do not support reloptions.
>
> Personally I'd be more worried about the unnest(). Also, please
> schema-qualify that function name; you can't assume anything about
> the search path here.
This version should fix these issues. I refrained from adding more ? :
expressions because it starts getting ugly for my taste.
| Attachment | Content-Type | Size |
|---|---|---|
| psql-toast-relopts-2.patch | text/x-diff | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2009-02-11 04:08:47 | pgsql: Clarify PQinitSSL() documentation to mention what the argument |
| Previous Message | Tom Lane | 2009-02-10 20:50:03 | Re: Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog, |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-02-11 01:41:45 | Re: Optimization rules for semi and anti joins |
| Previous Message | Jonah H. Harris | 2009-02-11 01:12:56 | Re: Optimization rules for semi and anti joins |