From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCHES] GIN improvements |
Date: | 2009-01-19 17:20:19 |
Message-ID: | 20090119172019.GF4132@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Teodor Sigaev wrote:
>> I notice you added a fillfactor reloption in ginoptions, but does it
>> really make sense? I recall removing it because the original code
>> contained a comment that says "this is here because default_reloptions
>> wants it, but it has no effect".
>
> I didn't change a recognition of fillfactor value, although GIN doesn't
> use it for now.
I suggest you take StdRdOptions out of the GinOptions struct, and leave
fillfactor out of ginoptions. I don't think there's much point in
supporting options that don't actually do anything. If the user tries
to set fillfactor for a gin index, he will get an error. Which is a
good thing IMHO.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
From | Date | Subject | |
---|---|---|---|
Next Message | Teodor Sigaev | 2009-01-19 17:45:16 | Re: tsearch with Turkish locale ( was Re: foreign_data test fails with non-C locale) |
Previous Message | Tom Lane | 2009-01-19 17:19:33 | Re: Fixes for compiler warnings |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-01-19 18:00:26 | Re: [PATCHES] GIN improvements |
Previous Message | Teodor Sigaev | 2009-01-19 17:17:14 | Re: [PATCHES] GIN improvements |