Skip site navigation (1) Skip section navigation (2)

pgsql: Fix a pg_dump output ordering problem introduced in 8.3 by the

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix a pg_dump output ordering problem introduced in 8.3 by the
Date: 2009-01-18 20:44:45
Message-ID: 20090118204445.F3149754878@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Fix a pg_dump output ordering problem introduced in 8.3 by the addition of
array types for composite types.  Although pg_dump understood it wasn't
supposed to dump these array types as separate objects, it must include
them in the dependency ordering analysis, and it was improperly assigning them
the same relatively-high sort priority as regular types.  This resulted in
effectively moving composite types and tables up to that same high priority,
which broke any ordering requirements that weren't explicitly enforced by
dependencies.  In particular user-defined operator classes, which should come
out before tables, failed to do so.  Per report from Brendan Jurd.

In passing, also fix an ill-considered decision to give text search objects
the same sort priority as functions and operators --- the sort result looks
a lot nicer if different object types are kept separate.  The recent
foreign-data patch had copied that decision, making the sort ordering even
messier :-(

Modified Files:
--------------
    pgsql/src/bin/pg_dump:
        pg_dump.c (r1.513 -> r1.514)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c?r1=1.513&r2=1.514)
        pg_dump.h (r1.146 -> r1.147)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.h?r1=1.146&r2=1.147)
        pg_dump_sort.c (r1.23 -> r1.24)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump_sort.c?r1=1.23&r2=1.24)

pgsql-committers by date

Next:From: Tom LaneDate: 2009-01-18 20:44:53
Subject: pgsql: Fix a pg_dump output ordering problem introduced in 8.3 by the
Previous:From: User H-saitoDate: 2009-01-18 13:19:43
Subject: psqlodbc - psqlodbc: take some notes.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group