Re: Proposal: new border setting in psql

From: "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: bruce(at)momjian(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Proposal: new border setting in psql
Date: 2009-01-08 15:15:31
Message-ID: 20090108101531.1da2d8e6.darcy@druid.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 07 Jan 2009 18:12:58 -0500
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "D'Arcy J.M. Cain" <darcy(at)druid(dot)net> writes:
> > Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> >> As I remember, no actual patch was posted for this.
>
> > There was. I am attaching it again in case there were any changes
> > to original files in the meantime.
>
> I think what Bruce meant to say is that this patch doesn't produce
> 100% spec-compliant ReST, and that almost-ReST doesn't seem like a
> good feature.

It is a great feature for people actually using ReST. However, the
feature is really just a logical extension to the existing border
attribute. The fact that it is useful to people using ReST is just a
happy coincidence. I don't think it should be referred to as the ReST
feature. My patch does not mention ReST in the doc changes.

By "logical extension" I mean this;

0: Underline column names with single line
1: Add lines between columns
2: Add table frame <<== Up to here already exists
3: Underline column names with double line and add line between rows

It might be argued that '3' should be split between '3' and '4' since it
is two changes but that's a minor matter. I can make that change to the
patch if anyone sees any value to that.

3: Add line between rows
4: Use double line between header line and data

--
D'Arcy J.M. Cain <darcy(at)druid(dot)net> | Democracy is three wolves
http://www.druid.net/darcy/ | and a sheep voting on
+1 416 425 1212 (DoD#0082) (eNTP) | what's for dinner.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2009-01-08 15:27:18 Re: Proposal: new border setting in psql
Previous Message Kevin Grittner 2009-01-08 14:45:25 Re: incoherent view of serializable transactions