Skip site navigation (1) Skip section navigation (2)

Re: Incorrect description of xmax and xip in functions docs

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-docs <pgsql-docs(at)postgresql(dot)org>, Jan Wieck <JanWieck(at)Yahoo(dot)com>
Subject: Re: Incorrect description of xmax and xip in functions docs
Date: 2009-01-08 01:30:18
Message-ID: 200901080130.n081UIu18076@momjian.us (view raw or flat)
Thread:
Lists: pgsql-docs
Simon Riggs wrote:
> 
> On Sun, 2008-09-07 at 08:31 -0400, Bruce Momjian wrote:
> > Simon Riggs wrote:
> > > 
> > > On Sat, 2008-09-06 at 21:31 -0400, Bruce Momjian wrote:
> > > > Applied, and attached.
> > > 
> > > Thanks.
> > > 
> > > > > And for txid_visible_in_snapshot() comment added:
> > > > > "Function should not be used with subtransaction xids. It is possible
> > > > > that this function will return a true result for a subtransaction xid
> > > > > that was actually still in progress at the time of the snapshot".
> > > > 
> > > > I think the cleaner solution is to throw an appropriate error if a
> > > > subtransaction xid is used, rather than adding documentation.
> > > 
> > > Or maybe check subtrans for it, as it really should be doing.
> > 
> > Yea, that's what I meant.  You can't be sure everyone is going to read
> > the documentation but they are sure to see the function results or error
> > message.
> 
> In fact, neither is possible. We cannot assume subtrans is available on
> the system on which the check is made, neither can we identify which
> xids are subtransactions and which are not.
> 
> The only way is to document it.

Sorry, I am just getting back to this.  Why would we not know if
something is a subtransaction or if subtransactions are supported?  Are
you assuming txid_visible_in_snapshot() will be used on different
servers?  What are these txid_* functions for anyway?

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-docs by date

Next:From: Simon RiggsDate: 2009-01-08 08:19:19
Subject: Re: Incorrect description of xmax and xip in functions docs
Previous:From: Виктор ВислобоковDate: 2008-12-25 09:32:48
Subject: Re: Current docs are too comlicated for new Postgre users; thoughts on improvement

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group