Insert conditional SPI_push/SPI_pop calls into InputFunctionCall,
OutputFunctionCall, and friends. This allows SPI-using functions to invoke
datatype I/O without concern for the possibility that a SPI-using function
will be called (which could be either the I/O function itself, or a function
used in a domain check constraint). It's a tad ugly, but not nearly as ugly
as what'd be needed to make this work via retail insertion of push/pop
operations in all the PLs.
This reverts my patch of 2007-01-30 that inserted some retail SPI_push/pop
calls into plpgsql; that approach only fixed plpgsql, and not any other PLs.
But the other PLs have the issue too, as illustrated by a recent gripe from
Back-patch to 8.2, which is as far back as this solution will work. It's
also as far back as we need to worry about the domain-constraint case, since
earlier versions did not attempt to check domain constraints within datatype
input. I'm not aware of any old I/O functions that use SPI themselves, so
this should be sufficient for a back-patch.
spi.c (r184.108.40.206 -> r220.127.116.11)
fmgr.c (r18.104.22.168 -> r22.214.171.124)
spi.h (r126.96.36.199 -> r188.8.131.52)
pl_exec.c (r184.108.40.206 -> r220.127.116.11)
pgsql-committers by date
|Next:||From: Bruce Momjian||Date: 2009-01-07 21:48:16|
|Subject: pgsql: Have current_query() use ActivePortal->sourceText rather than |
|Previous:||From: Tom Lane||Date: 2009-01-07 20:39:05|
|Subject: pgsql: Insert conditional SPI_push/SPI_pop calls into InputFunctionCall, |