Andrew Dunstan wrote:
> Attached is the latest parallel restore patch. I think this is getting
> fairly close.
Some random comments
- please #define the return type of prestore(). Also, that it returns
in one platform and exits in another seems weird as an API. I think it
should return in both cases, and have the caller act appropriately.
- RestoreArchiveParallel has too many #ifdef WIN32. It should be
possible to split it so that the cruft is contained better.
- Aren't there too many checks for libz presence?
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
In response to
pgsql-hackers by date
|Next:||From: Martin Pihlak||Date: 2009-01-04 20:13:42|
|Subject: Re: dblink vs SQL/MED|
|Previous:||From: Tom Lane||Date: 2009-01-04 18:01:06|
|Subject: Re: pg_stats queries versus per-database encodings |