Skip site navigation (1) Skip section navigation (2)

Re: generic reloptions improvement

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Subject: Re: generic reloptions improvement
Date: 2008-12-30 15:31:14
Message-ID: 20081230153114.GC3863@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackers
Alvaro Herrera wrote:
> Tom Lane wrote:
> > Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> 
> > > I'm intending to have a new routine which would reserve a value at
> > > runtime.  This value would be later be passed by the AM to create new
> > > options on the table.
> > 
> > What do you mean by "at runtime"?  Surely the value would have to remain
> > stable across database restarts, since it's going to relate to stuff
> > that is in catalog entries.
> 
> No, there's no need for the value to be stable across restart; what's
> stored in catalogs is the option name, which is linked to the kind
> number only in the parser table.

So this is an updated patch.  This now allows a user-defined AM to
create new reloptions and pass them down to the parser for parsing and
checking.  I also attach a proof-of-concept patch that adds three new
options to btree (which do nothing apart from logging a message at
insert time).  This patch demonstrates the coding pattern that a
user-defined AM should follow to add and use new storage options.

The main thing I find slightly hateful about this patch is that the code
to translate from the returned relopt_value array and the fixed struct
is rather verbose; and that the AM needs to duplicate the code in
default_reloptions.  I don't find it ugly enough to warrant objecting to
the patch as a whole however.

The neat thing about this code is that the parsing and searching is done
only once, when the relcache entry is loaded.  Later accesses to the
option values themselves is just a struct access, and thus plenty quick.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Attachment: reloptions-extra-btree.patch
Description: text/x-diff (3.7 KB)
Attachment: reloptions-6.patch
Description: text/x-diff (25.4 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-12-30 15:35:35
Subject: Re: version() output vs. 32/64 bits
Previous:From: Heikki LinnakangasDate: 2008-12-30 15:20:36
Subject: Re: Hot standby and b-tree killed items

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group