Skip site navigation (1) Skip section navigation (2)

pgsql: Don't use OidIsValid to check the return value of

From: heikki(at)postgresql(dot)org (Heikki Linnakangas)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't use OidIsValid to check the return value of
Date: 2008-12-20 09:40:56
Message-ID: 20081220094056.7319A7563FE@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Log Message:
-----------
Don't use OidIsValid to check the return value of transformGenericOptions,
because transformGenericOptions returns an array, not an Oid. I'm not
sure if this fixes the crashes seen in buildfarm, but it should be fixed
anyway.

Modified Files:
--------------
    pgsql/src/backend/commands:
        foreigncmds.c (r1.1 -> r1.2)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/foreigncmds.c?r1=1.1&r2=1.2)

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2008-12-20 09:44:25
Subject: Re: [COMMITTERS] pgsql: SQL/MED catalog manipulation facilities This doesn't do any
Previous:From: Heikki LinnakangasDate: 2008-12-20 09:10:21
Subject: Re: Hot standby and b-tree killed items

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2008-12-20 09:44:25
Subject: Re: [COMMITTERS] pgsql: SQL/MED catalog manipulation facilities This doesn't do any
Previous:From: Sergey E. KoposovDate: 2008-12-20 07:34:22
Subject: Re: [COMMITTERS] pgsql: SQL/MED catalog manipulation facilities This doesn't do any

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group