Re: pgsql: Enable script to generate preproc.y in build process.

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: badalex(at)gmail(dot)com, Michael Meskes <meskes(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Enable script to generate preproc.y in build process.
Date: 2008-11-16 10:05:10
Message-ID: 20081116100510.GA19122@feivel.credativ.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Nov 15, 2008 at 05:39:49PM -0500, Tom Lane wrote:
> Interesting. Looking at the generated code, it seems that the older
> bison versions I have here (2.3 and 1.875) insert an extra semicolon at
> the end of any action. Apparently 2.4 doesn't do that anymore ...
> I wonder how many other projects' code will break?

Me too. The ecpg.trailer code was just copied from the old preproc.y so I guess
this bug has been in before we moved to the new automatic build. Could we get
one of the buildfarm members to upgrade to bison 2.4? Even if we now compile
through cleanly on that one test system, I'd rather have a regular build using
this new version.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-11-16 16:33:06 Re: pgsql: Enable script to generate preproc.y in build process.
Previous Message Tom Lane 2008-11-15 22:39:49 Re: pgsql: Enable script to generate preproc.y in build process.

Browse pgsql-hackers by date

  From Date Subject
Next Message Martijn van Oosterhout 2008-11-16 11:08:57 Re: Block-level CRC checks
Previous Message Oleg Serov 2008-11-16 10:03:59 Re: Pl/Perl function: Speed of the First time executing pl/perl function in connection;