From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Markus Wanner <markus(at)bluegap(dot)ch>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: WIP: Column-level Privileges |
Date: | 2008-11-14 21:38:11 |
Message-ID: | 20081114213811.GK3830@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera wrote:
> I didn't check the rest of the code, so don't count this as a review.
I had a look at aclchk.c and didn't like your change to
objectNamesToOids; seems rather baroque. I changed it per the attached
patch.
Moreover I didn't very much like the way aclcheck_error_col is dealing
with two or one % escapes. I think you should have a separate routine
for the column case, and prepend a dummy string to no_priv_msg.
Why is there a InternalGrantStmt.rel_level? Doesn't it suffice to
check whether col_privs is NIL?
Is there enough common code in ExecGrant_Relation to justify the way you
have it? Can the common be refactored in a better way that separates
the two cases more clearly?
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Attachment | Content-Type | Size |
---|---|---|
colprivs_wip.2008111401-2008111402.inter.patch | text/x-diff | 4.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2008-11-14 21:51:33 | Re: Okay, DLLIMPORT is making me crazy |
Previous Message | Robert Haas | 2008-11-14 21:32:28 | "ORDER BY" clause prevents "UPDATE WHERE CURRENT OF" |