Re: [PATCHES] odd output in restore mode

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Martin Zaun <Martin(dot)Zaun(at)Sun(dot)COM>, Greg Smith <gsmith(at)gregsmith(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Dave Page <dpage(at)pgadmin(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, List pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] odd output in restore mode
Date: 2008-11-11 22:24:41
Message-ID: 200811112224.mABMOfj27949@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Have we made any progress on this, namely better documentation and
removing the Win32 delay code?

---------------------------------------------------------------------------

Andrew Dunstan wrote:
>
>
> Simon Riggs wrote:
> > Well, this is a strange conclusion, leaving me slightly bemused.
> >
> > The discussion between Andrew and I at PGcon concluded that we would
> > * document which other tools to use
> > * remove the delay
> >
> > Now we have rejected the patch which does that, but then re-requested
> > the exact same thing again.
> >
> > The patch interprets "remove the delay" as "remove the delay in a way
> > which will not screw up existing users of pg_standby when they upgrade".
> > Doing that requires us to have a configurable delay, which defaults to
> > the current behaviour, but that can be set to zero (the recommended
> > way). Which is what the patch implements.
> >
> > Andrew, Heikki: ISTM its time to just make the changes yourselves. This
> > is just going round and round to no benefit. This doesn't warrant such a
> > long discussion and review process.
> >
>
> You ought to know by now that the length and ferocity of the discussion
> bears no relation at all to the importance of the subject ;-)
>
> Personally, I think it's reasonable to provide the delay as long as it's
> switchable, although I would have preferred zero to be the default. If
> we remove it altogether then we force bigger changes on people who are
> currently using Windows copy. But I can live with that since changing
> their archive_command is the better path by far anyway, either to use
> Gnu cp or the copy / rename trick.
>
> cheers
>
> andrew
>

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2008-11-11 23:09:09 Re: [PATCHES] odd output in restore mode
Previous Message Jaime Casanova 2008-11-11 21:48:02 Re: failed test float8 on mingw

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2008-11-11 23:09:09 Re: [PATCHES] odd output in restore mode
Previous Message Hiroshi Saito 2008-11-11 14:10:29 Re: [PATCHES] Solve a problem of LC_TIME of windows.