Re: BUG #4496: Memory leak in pg_dump.c?

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Aggro <dvice_null(at)yahoo(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #4496: Memory leak in pg_dump.c?
Date: 2008-10-30 20:00:16
Message-ID: 20081030200016.GL3857@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Aggro wrote:
>
> --- Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> wrote:
>

> > I think all information is collected and they are
> > used for all pg_dump run. It
> > does not make sense to free them. See line 725.
>
> But is the memory freed at some point? E.g. when
> program shuts down? If it is not freed ever, then it
> is a memory leak.

A pg_dump run is comparatively short-lived, so if Zdenek is right then
there's no important leak here -- we're counting on program exit to
release the memory. There's probably little point in releasing things
earlier than that.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2008-10-30 20:06:28 Re: BUG #4496: Memory leak in pg_dump.c?
Previous Message Aggro 2008-10-30 19:51:46 Re: BUG #4496: Memory leak in pg_dump.c?