Skip site navigation (1) Skip section navigation (2)

Re: minimal update

From: David Fetter <david(at)fetter(dot)org>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>,Kenneth Marshall <ktm(at)rice(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Simon Riggs <simon(at)2ndQuadrant(dot)com>,Robert Haas <robertmhaas(at)gmail(dot)com>,Magnus Hagander <magnus(at)hagander(dot)net>,Bruce Momjian <bruce(at)momjian(dot)us>,Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>,Michael Glaesemann <grzm(at)seespotcode(dot)net>,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: minimal update
Date: 2008-10-29 20:08:29
Message-ID: 20081029200829.GA18097@fetter.org (view raw or flat)
Thread:
Lists: pgsql-hackers
On Wed, Oct 29, 2008 at 03:48:09PM -0400, Andrew Dunstan wrote:
>
>>> +     /* make sure it's called as a trigger */
>>> +     if (!CALLED_AS_TRIGGER(fcinfo))
>>> +         elog(ERROR, "suppress_redundant_updates_trigger: must be called as trigger");
>>
>> Shouldn't these all be ereport()?
>
> Good point.
>
> I'll fix them.
>
> Maybe we should fix our C sample trigger, from which this was taken.

Yes :)

Does the attached have the right error code?

Cheers,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2008-10-29 20:20:15
Subject: Re: minimal update
Previous:From: Gevik BabakhaniDate: 2008-10-29 20:04:27
Subject: Re: PostgreSQL network discovery

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group