Re: Parsing errors in pg_hba.conf

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parsing errors in pg_hba.conf
Date: 2008-10-27 12:19:33
Message-ID: 20081027121933.GA3866@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander wrote:
> In a number of places in pg_hba.conf, we don't actually log what goes
> wrong - instead we just goto a label that will log "invalid token \"%s\"".
>
> Is there any special reason for this, other than the fact that it was
> the easy way out? I think it would be reasonable to for example log
> "hostssl not supported on this platform" instead of that, when USE_SSL
> is not defined, etc.

Without actually looking at what you're considering, I think it could be
a security bug if you were to disclose all the details to the user.
Perhaps the details can be passed to errdetail_log() to avoid this
problem.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-10-27 12:27:13 Re: Parsing errors in pg_hba.conf
Previous Message Tom Lane 2008-10-27 12:18:07 Re: new correlation metric