pgsql: Fix more problems with rewriter failing to set Query.hasSubLinks

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix more problems with rewriter failing to set Query.hasSubLinks
Date: 2008-09-24 16:52:46
Message-ID: 20080924165246.3EEB17545A4@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix more problems with rewriter failing to set Query.hasSubLinks when inserting
a SubLink expression into a rule query. We missed cases where the original
query contained a sub-SELECT in a function in FROM, a multi-row VALUES list,
or a RETURNING list. Per bug #4434 from Dean Rasheed and subsequent
investigation.

Back-patch to 8.1; older releases don't have the issue because they didn't
try to be smart about setting hasSubLinks only when needed.

Modified Files:
--------------
pgsql/src/backend/rewrite:
rewriteHandler.c (r1.179 -> r1.180)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/rewrite/rewriteHandler.c?r1=1.179&r2=1.180)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-09-24 16:52:53 pgsql: Fix more problems with rewriter failing to set Query.hasSubLinks
Previous Message Bruce Momjian 2008-09-24 16:30:27 pgsql: Fix markup tag error, envvar -> envar.