Skip site navigation (1) Skip section navigation (2)

Re: Solve a problem of LC_TIME of windows.

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Solve a problem of LC_TIME of windows.
Date: 2008-09-24 14:15:19
Message-ID: 20080924141519.GA10480@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Magnus Hagander wrote:

> Also, the patch needs error checking. strftime() can fail, and the
> multibyte conversion functions can certainly fail. That will need to be
> added.

What about this line?

#define STRLEN_MAX 255

Are we really sure the strftime format cannot be longer than that?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2008-09-24 14:28:54
Subject: Re: Initial prefetch performance testing
Previous:From: KaiGai KoheiDate: 2008-09-24 14:13:18
Subject: Re: Updates of SE-PostgreSQL 8.4devel patches

pgsql-patches by date

Next:From: Hiroshi SaitoDate: 2008-09-24 14:55:10
Subject: Re: Solve a problem of LC_TIME of windows.
Previous:From: Simon RiggsDate: 2008-09-24 12:48:45
Subject: Re: [PATCHES] Subtransaction commits and Hot Standby

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group