Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] 0x1A in control file on Windows

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org, pgsql-bugs(at)postgresql(dot)org
Subject: Re: [HACKERS] 0x1A in control file on Windows
Date: 2008-09-23 21:24:31
Message-ID: 200809232124.m8NLOVx06472@momjian.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
Tom Lane wrote:
> ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> > I found a bug that pg_controldata ends with error if control files
> > contain 0x1A (Ctrl+Z) on Windows.
> 
> > We probably need to add PG_BINARY when we open control files
> > because 0x1A is an end-of-file marker on Windows.
> 
> Well, why is that a bug?  If the platform is so silly as to define text
> files that way, who are we to argue?

The problem is that our pg_controldata might have binary values that
contain 0x1a that will be confused by the operating system as
end-of-file.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: Hannu KrosingDate: 2008-09-23 21:24:33
Subject: Re: Toasted table not deleted when no out of linecolumns left
Previous:From: Magnus HaganderDate: 2008-09-23 21:18:35
Subject: Re: 8.3 .4 + Vista + MingW + initdb = ACCESS_DENIED

pgsql-bugs by date

Next:From: toruvinnDate: 2008-09-23 22:51:01
Subject: Re: BUG #4433: entries like "host all all 10.0.50.31/0 ..." should not be allowed or trigger a warning
Previous:From: Hal BlackDate: 2008-09-23 19:33:36
Subject: Re: BUG #4435: pg_ctl start doesn't detach when run via SSH

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group