Here is a revised patch to renewal NDirectFileRead/Write.

> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > * Let's rename them BufFileReadCount and BufFileWriteCount to reflect
> > their actual purpose.
> > * In any case I agree that the current arrangement
> > with execdebug.h declaring variables defined in bufmgr.c is just weird.

- NDirectFile{Read|Write} are renamed to BufFile{Read|Write}Count.
- They are still declared in execdebug.h and buffile.c includes it.


I did not touch messages in ShowBufferUsage() in the patch.
I think it still has meaning because BufFile counters are
kinds of direct block access.

> ShowBufferUsage()
> !   Shared blocks: ...
> !   Local  blocks: ...
> !   Direct blocks: <R> read, <W> written

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center

In response to

• Re: NDirectFileRead and Write at 2008-09-12 10:24:34 from ITAGAKI Takahiro

Responses

• Re: NDirectFileRead and Write at 2008-09-17 13:21:33 from Tom Lane

pgsql-hackers by date

Next:	From: Tom Lane	Date: 2008-09-16 02:40:33
	Subject: Re: plpgsql is not translate-aware
Previous:	From: KaiGai Kohei	Date: 2008-09-16 01:32:11
	Subject: Re: Proposal of SE-PostgreSQL patches (for CommitFest:Sep)