Skip site navigation (1) Skip section navigation (2)

Re: NDirectFileRead and Write

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: NDirectFileRead and Write
Date: 2008-09-16 01:56:29
Message-ID: 20080916104812.7E68.52131E4D@oss.ntt.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackers
Here is a revised patch to renewal NDirectFileRead/Write.

> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > * Let's rename them BufFileReadCount and BufFileWriteCount to reflect
> > their actual purpose.
> > * In any case I agree that the current arrangement
> > with execdebug.h declaring variables defined in bufmgr.c is just weird.

- NDirectFile{Read|Write} are renamed to BufFile{Read|Write}Count.
- They are still declared in execdebug.h and buffile.c includes it.


I did not touch messages in ShowBufferUsage() in the patch.
I think it still has meaning because BufFile counters are
kinds of direct block access.

> ShowBufferUsage()
> !   Shared blocks: ...
> !   Local  blocks: ...
> !   Direct blocks: <R> read, <W> written

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center


Attachment: BufFileCount.patch
Description: application/octet-stream (3.9 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-09-16 02:40:33
Subject: Re: plpgsql is not translate-aware
Previous:From: KaiGai KoheiDate: 2008-09-16 01:32:11
Subject: Re: Proposal of SE-PostgreSQL patches (for CommitFest:Sep)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group